[GitHub] [superset] justinpark opened a new pull request, #21968: fix: invalid float number format by json-bigint

[GitBox]

justinpark opened a new pull request, #21968:
URL: https://github.com/apache/superset/pull/21968

   ### SUMMARY
   This commit fixes the regression from #21937
   There's [a known 
issue](https://github.com/sidorares/json-bigint/issues/74#issuecomment-1284992714)
 for floating value formatting on current latest version of `json-bigint` open 
source.
   
   Since the main contributor no longer maintain the new release, this commit 
replaces the open-source library by `json-bigint-native` which is branched out 
from `json-bigint` and fixes the known bugs including float value issue.
   This commit also adds the extra specs to verify the floating value 
formatting.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   <img width="395" alt="Screen Shot 2022-10-28 at 11 22 12 AM" 
src="https://user-images.githubusercontent.com/1392866/198705963-0409fdfa-f633-44fa-9490-de932e74c498.png";>
   
   After:
   
   <img width="468" alt="Screen Shot 2022-10-28 at 11 22 18 AM" 
src="https://user-images.githubusercontent.com/1392866/198705989-0c6009d1-3911-4dc3-9f4e-b20a1cd4467b.png";>
   
   ### TESTING INSTRUCTIONS
   Create a chart with floating numbers
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org