eschutho commented on code in PR #21627: URL: https://github.com/apache/superset/pull/21627#discussion_r1008464086
########## superset/reports/commands/exceptions.py: ########## @@ -163,10 +165,12 @@ class ReportScheduleExecuteUnexpectedError(CommandException): class ReportSchedulePreviousWorkingError(CommandException): + status = 429 Review Comment: Thanks @dpgaspar! @john-bodley, @betodealmeida and I were talking about `error_type`s as well and concluded that errors should not be raised, only exceptions, and that we can include errors with an exception, but not raise them. Do you have thoughts on that @dpgaspar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
