ktmud commented on PR #21912: URL: https://github.com/apache/superset/pull/21912#issuecomment-1296547217
Not sure if this has been discussed, but why can't this be stored in the existing [encrypted_extra](https://github.com/apache/superset/blob/eac6fdcd29a8e0476b153d1452a0bd2a77b47fa4/superset/models/core.py#L150) field? It's already been used for things like [Google Sheets](https://github.com/apache/superset/blob/34a79add04d4525c164699248c30c9d6588c876d/tests/unit_tests/databases/api_test.py#L72-L91) and BigQuery connections, why would SSH tunnel credentials be different? It seems to me you can just updated the `unmask_encrypted_extra` in `BaseEngineSpec` if you want to enable SSH tunnel for all databases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
