ktmud commented on issue #20630: URL: https://github.com/apache/superset/issues/20630#issuecomment-1297603192
The reason I wanted to keep a `views` folder is exactly to call-out the legacy code so they can be more proactively cleaned up. The `views` folder can be removed once everything is migrated to client-side rendering. > The one aspect I'm not entirely sure about is whether the existing model definitions are actually DAO-esque in nature and would need to be refactored Yes, I was thinking of the same thing. `models` should just be a thin layer of SQLAlchemy's declaritive mapping + some shared classes & mixins. We can have an explicit DAO layer, or, just stay simple and put more things in "commands" instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
