justinpark opened a new pull request, #21999: URL: https://github.com/apache/superset/pull/21999
### SUMMARY Since `addNewQueryEditor` action handled differently between shortkey and the tab button, it pops up the new tab in a different configuration. This commit consolidates the `addNewQueryEditor` action to configure the new tab setting consistently. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF - Before https://user-images.githubusercontent.com/1392866/199376112-538577e5-03fd-437e-b861-a098adfb5fa6.mov - After https://user-images.githubusercontent.com/1392866/199376105-d52fa2cf-54a6-42cc-ba6f-f755a91f2d94.mov ### TESTING INSTRUCTIONS - Go to SqlLab - Click "+" button to open a new tab - Switch to the previous tab - Hit Ctrl + t (mac) / Ctrl + q (windows) to open a new tab - Compare the content with the previous step ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
