justinpark opened a new pull request, #22050:
URL: https://github.com/apache/superset/pull/22050

   ### SUMMARY
   There's [an open issue](https://github.com/apache/superset/issues/11123) 
that is hard to distinguish icons between running and successful query state in 
sqllab.
   This commit adds the animated dimming translation for running statue to be 
distinguishing the running state easily.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   - Before:
   
   <img width="436" alt="Screen_Shot_2022-11-07_at_2_49_13_PM" 
src="https://user-images.githubusercontent.com/1392866/200432585-f763df31-a3e2-49ec-927b-e9ae26c64cde.png";>
   
   - After:
   
   
![dimming](https://user-images.githubusercontent.com/1392866/200432615-11a816e7-d52f-4106-92b3-8087e4e88062.gif)
   
   
   ### TESTING INSTRUCTIONS
   Go to sqllab
   Run a query
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: 
[issues#11123](https://github.com/apache/superset/issues/11123) 
[issues#13648](https://github.com/apache/superset/issues/13648)
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to