john-bodley commented on code in PR #21729: URL: https://github.com/apache/superset/pull/21729#discussion_r1016738040
########## superset/connectors/sqla/models.py: ########## @@ -119,6 +119,7 @@ from superset.superset_typing import ( AdhocColumn, AdhocMetric, + Column as ColumnTyping, Review Comment: @mayurnewase out of interest why did you rename this? There doesn't seem to be a name clash per your change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org