EugeneTorap commented on code in PR #22093:
URL: https://github.com/apache/superset/pull/22093#discussion_r1019549309
##########
superset-frontend/src/SqlLab/components/SqlEditor/SqlEditor.test.jsx:
##########
@@ -263,8 +262,8 @@ describe('SqlEditor', () => {
it('render a Limit Dropdown', async () => {
const defaultQueryLimit = 101;
const updatedProps = { ...mockedProps, defaultQueryLimit };
- const wrapper = buildWrapper(updatedProps);
- await waitForComponentToPaint(wrapper);
- expect(wrapper.find(AntdDropdown)).toExist();
+ const { findByText } = setup(updatedProps, store);
+ fireEvent.click(await findByText('LIMIT:'));
Review Comment:
> Most projects have a few use cases for fireEvent, but the majority of the
time you should probably use
[@testing-library/user-event](https://testing-library.com/docs/user-event/intro).
Should we use `user-event` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
