geido commented on code in PR #22064: URL: https://github.com/apache/superset/pull/22064#discussion_r1021459057
########## superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Horizontal.tsx: ########## @@ -0,0 +1,130 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import React from 'react'; +import { styled, t } from '@superset-ui/core'; +import Icons from 'src/components/Icons'; +import Loading from 'src/components/Loading'; +import FilterControls from './FilterControls/FilterControls'; +import { getFilterBarTestId, HorizontalBarProps } from './utils'; +import FilterBarLocationSelect from './FilterBarLocationSelect'; +import FilterConfigurationLink from './FilterConfigurationLink'; + +const HorizontalBar = styled.div` + ${({ theme }) => ` + padding: ${theme.gridUnit * 2}px ${theme.gridUnit * 2}px; + background: ${theme.colors.grayscale.light5}; + box-shadow: inset 0px -2px 2px -1px ${theme.colors.grayscale.light2}; +`} +`; + +const HorizontalBarContent = styled.div` + ${({ theme }) => ` + display: flex; + flex-direction: row; + flex-wrap: nowrap; + align-items: center; + justify-content: flex-start; + padding: 0 ${theme.gridUnit * 2}px; + + .loading { + margin: ${theme.gridUnit * 2}px auto ${theme.gridUnit * 2}px; + padding: 0; + } +`} +`; + +const FilterBarEmptyStateContainer = styled.div` + ${({ theme }) => ` + margin: 0 ${theme.gridUnit * 2}px; Review Comment: > I think according to the designs, distance between the gear and this message should be 18px. Increased to 16px which seems to be the most common spacing value in the horizontal filter bar. I think it looks balanced this way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
