eschutho commented on code in PR #21986:
URL: https://github.com/apache/superset/pull/21986#discussion_r1021884418
##########
superset/datasets/dao.py:
##########
@@ -35,6 +37,26 @@ class DatasetDAO(BaseDAO): # pylint:
disable=too-many-public-methods
model_cls = SqlaTable
base_filter = DatasourceFilter
+ @classmethod
+ def find_by_ids(cls, model_ids: Union[List[str], List[int]]) ->
List[SqlaTable]:
Review Comment:
I also mentioned it in the PR description, but yes tests were failing on
dataset deletion due to sqlalchemy not having access to the database
relationship in the session. I found other logs of this happening for this
command, and fixed it here for the tests to pass. There was a query in the
after update hook that I removed that was re-loading the database into the
session as an unexpected side-effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
