michael-s-molina commented on code in PR #22135:
URL: https://github.com/apache/superset/pull/22135#discussion_r1025436804
##########
superset-frontend/src/components/Table/Table.stories.tsx:
##########
@@ -286,31 +321,37 @@ Basic.args = {
columns: basicColumns,
size: TableSize.SMALL,
onRow: handlers,
+ usePagination: false,
+};
+
+export const Pagination: ComponentStory<typeof Table> = args => (
+ <Table {...args} />
+);
+
+Pagination.args = {
+ data: basicData,
+ columns: basicColumns,
+ size: TableSize.SMALL,
pageSizeOptions: ['5', '10', '15', '20', '25'],
- defaultPageSize: 10,
+ defaultPageSize: 5,
};
-export const ManyColumns: ComponentStory<typeof Table> = args => (
- <ThemeProvider theme={supersetTheme}>
- <div style={{ height: '350px' }}>
- <Table {...args} />
- </div>
- </ThemeProvider>
+export const VirtualizedPerformance: ComponentStory<typeof Table> = args => (
+ <Table {...args} />
);
-ManyColumns.args = {
+VirtualizedPerformance.args = {
data: bigdata,
columns: bigColumns,
size: TableSize.SMALL,
resizable: true,
reorderable: true,
height: 350,
+ virtualize: true,
Review Comment:
I think this story is better represented if pagination is off by default.
```suggestion
virtualize: true,
usePagination: false,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
