[GitHub] [superset] michael-s-molina commented on pull request #22135: feat: Adds virtualization option to antd based Table component

[GitBox]

michael-s-molina commented on PR #22135:
URL: https://github.com/apache/superset/pull/22135#issuecomment-1325219281

   @eric-briscoe We have the concept of column formatting as you can see in the 
screenshot below:
   
   <img width="868" alt="Screen Shot 2022-11-23 at 9 45 37 AM" 
src="https://user-images.githubusercontent.com/70410625/203575842-74bd0c22-1342-4662-a2b8-53cd2f7490a4.png";>
   
   I'm wondering about the best approach to implement this. It looks pretty 
similar to the 
[filters](https://ant.design/components/table#components-table-demo-head) 
concept provided by Ant Design's table. If we follow the same pattern, we can 
have `formattings`, `defaultFormatting`, `onFormatting` properties on 
`ColumnsType` to create the popup selector. We would also need to provide a 
`TimeCell` renderer that can be used when rendering dates/timestamps/numbers. 
WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org