kgabryje opened a new pull request, #22207: URL: https://github.com/apache/superset/pull/22207
### SUMMARY This PR fixes 2 issues: 1. Due to some faulty logic on the frontend, sometimes we converted `metric` control value from a string to an array. That resulted in `Unhashable type: 'list' error`. 2. When user opened a chart, changed dataset, then changed viz type, and then clicked "Update chart", Explore would crash with `undefined` error. That's because of the fact that we were expecting all the controls from the previous viz type to still be available and have values, which might not be the case after changing viz type. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: 1. https://user-images.githubusercontent.com/15073128/203598667-a73f8fd8-c648-423e-8914-e010144c35a5.mov 2. https://user-images.githubusercontent.com/15073128/203598799-73d5e33f-b679-4cb5-8b5e-42e8315a26b0.mov After: 1. https://user-images.githubusercontent.com/15073128/203600227-494d33ec-07f4-4d1c-aac2-9bd122243bc3.mov ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
