codyml opened a new pull request, #22265: URL: https://github.com/apache/superset/pull/22265
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The horizontal filter bar for native filters isn't currently fully hidden behind the `HORIZONTAL_FILTER_BAR` feature flag: the flag currently only controls whether the gear icon is shown in vertical mode. As such, if you enable the FF, change a dashboard's filter bar to horizontal, then disable the FF, the bar stays horizontal. This PR changes this behavior so if the FF is off, every filter bar will always display vertically. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before w/ FF off: <img width="1114" alt="Screen Shot 2022-11-29 at 1 26 08 PM" src="https://user-images.githubusercontent.com/13007381/204640649-6552d48e-b983-4837-8125-0f6a8a044b76.png";> After w/ FF off: <img width="1114" alt="Screen Shot 2022-11-29 at 1 26 37 PM" src="https://user-images.githubusercontent.com/13007381/204640666-f404780e-4abb-458f-9f77-ca0725b9fa4d.png";> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Check that the horizontal filter bar looks the same as before with the FF on - **These steps need to be taken in an environment where you can control feature flags without resetting the DB, e.g. local dev instead of ephemeral env:** - Turn on the FF and reload - Using the dev console, confirm that the FF is on by checking the value of `window.featureFlags.HORIZONTAL_FILTER_BAR` - Go to a dashboard and change the native filter bar orientation to horizontal - Turn off the FF and reload - Using the dev console, confirm that the FF is ff by checking the value of `window.featureFlags.HORIZONTAL_FILTER_BAR` - Confirm that the native filter bar orientation is vertical ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Required feature flags: `HORIZONTAL_FILTER_BAR` - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/13007381/204640649-6552d48e-b983-4837-8125-0f6a8a044b76.png"](https://user-images.githubusercontent.com/13007381/204640649-6552d48e-b983-4837-8125-0f6a8a044b76.png"){kind=link}
![https://user-images.githubusercontent.com/13007381/204640666-f404780e-4abb-458f-9f77-ca0725b9fa4d.png"](https://user-images.githubusercontent.com/13007381/204640666-f404780e-4abb-458f-9f77-ca0725b9fa4d.png"){kind=link}