eschutho commented on code in PR #22201: URL: https://github.com/apache/superset/pull/22201#discussion_r1035419275
########## superset/databases/ssh_tunnel/commands/create.py: ########## @@ -20,16 +20,24 @@ from flask_appbuilder.models.sqla import Model from marshmallow import ValidationError + +from superset import app, is_feature_enabled from superset.commands.base import BaseCommand from superset.dao.exceptions import DAOCreateFailedError from superset.databases.dao import DatabaseDAO from superset.databases.ssh_tunnel.commands.exceptions import SSHTunnelCreateFailedError from superset.databases.ssh_tunnel.dao import SSHTunnelDAO +config = app.config +ssh_tunnel_manager = config["SSH_TUNNEL_MANAGER"] + logger = logging.getLogger(__name__) class CreateSSHTunnelCommand(BaseCommand): + def __str__(self) -> str: + return super().__str__() Review Comment: isn't this redundant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
