[GitHub] [superset] codyml opened a new pull request, #22288: fix(native-filters): Misc spacing fixes for horizontal and horizontal overflow filter bar items

[GitBox]

codyml opened a new pull request, #22288:
URL: https://github.com/apache/superset/pull/22288

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This PR tightens up some styles:
   - There is no longer double divider lines when a divider is the first item 
in the horizontal filter bar.
   - The initial divider line and the other divider lines in the horizontal 
filter bar are now the same height.
   - Text spacing in the overflow menu is now more uniform.
   - The "Filters out of scope" item in horizontal overflow no longer has 
unbalanced top/bottom margin when it's the only item.
   - "Filters out of scope" in horizontal overflow contents are now more 
consistently spaced.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   <img width="594" alt="Screen Shot 2022-11-30 at 4 24 02 PM" 
src="https://user-images.githubusercontent.com/13007381/204933929-add0be3f-a0bb-41f1-9690-845fd7c5490a.png";>
   <img width="647" alt="Screen Shot 2022-11-30 at 4 24 34 PM" 
src="https://user-images.githubusercontent.com/13007381/204933942-898e4627-0e44-416c-9b04-e02465b4c595.png";>
   <img width="384" alt="Screen Shot 2022-11-30 at 4 24 59 PM" 
src="https://user-images.githubusercontent.com/13007381/204933948-c7a8083d-660f-43cf-be75-49bf5009e4bb.png";>
   <img width="444" alt="Screen Shot 2022-11-30 at 4 25 03 PM" 
src="https://user-images.githubusercontent.com/13007381/204933955-e40b698c-1b54-4fe7-9ec9-4c84f3f6a0e7.png";>
   
   After:
   <img width="629" alt="Screen Shot 2022-11-30 at 4 22 34 PM" 
src="https://user-images.githubusercontent.com/13007381/204933886-0b11581d-ec25-4f3a-ade9-79ef1886a5dd.png";>
   <img width="647" alt="Screen Shot 2022-11-30 at 4 22 45 PM" 
src="https://user-images.githubusercontent.com/13007381/204933894-a837aad4-6b42-496f-92ee-e619d78d11bf.png";>
   <img width="410" alt="Screen Shot 2022-11-30 at 4 23 08 PM" 
src="https://user-images.githubusercontent.com/13007381/204933907-11fffecf-7347-47df-b4ea-16f96fcb9c22.png";>
   <img width="508" alt="Screen Shot 2022-11-30 at 4 23 13 PM" 
src="https://user-images.githubusercontent.com/13007381/204933920-d4b42121-0929-4fc6-b532-4086c02f2052.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   - Check that the above spacing/styling issues are resolved.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Required feature flags: `HORIZONTAL_FILTER_BAR`
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org