codyml opened a new pull request, #22307: URL: https://github.com/apache/superset/pull/22307
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR follows up on a few comments from previous PRs: - https://github.com/apache/superset/pull/22288#discussion_r1036916081: Replaces use of fractional grid units with full grid units (with almost no visible change) - https://github.com/apache/superset/pull/22260#discussion_r1035442923: Adds type guard for checking if native filter has a value set and removes now-unnecessary uses of `FilterWithDataMask` - https://github.com/apache/superset/pull/22265: Adds an additional guard if the `HORIZONTAL_FILTER_BAR` feature flag is off, so Redux state will match behavior ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> No visible changes ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - There shouldn't be any new lint/build errors - Horizontal overflow dividers should look (essentially) the same as before - If a filter bar is set to horizontal then the feature flag is turned off, checking the Redux state should show `filterBarOrientation` set to vertical ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: `HORIZONTAL_FILTER_BAR` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
