[GitHub] [superset] michael-s-molina commented on a diff in pull request #22332: chore(datasets): Add /api/v1/dataset/{pk}/column endpoint

[GitBox]

michael-s-molina commented on code in PR #22332:
URL: https://github.com/apache/superset/pull/22332#discussion_r1042202494


##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ColumnSelect.tsx:
##########
@@ -98,17 +98,17 @@ export function ColumnSelect({
     }
     if (datasetId != null) {
       cachedSupersetGet({
-        endpoint: `/api/v1/dataset/${datasetId}`,
+        endpoint: `/api/v1/dataset/${datasetId}/column`,

Review Comment:
   +1 on `columns` as it represents a set of columns. 
   
   I added a ticket to [Superset 3.0 project 
board](https://github.com/apache/superset/projects/49) to refactor the 
endpoints to use the plural form.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org