villebro commented on PR #22328: URL: https://github.com/apache/superset/pull/22328#issuecomment-1344779780
> Code LGMT. > > > > @villebro If you don't mind, it would be a good idea to also get @dpgaspar's approval before merging it. Thank you for the improvement! Absolutely @michael-s-molina 👍 As I also found a bug today in the PR I'm going to let it simmer over the weekend as I feel there's room for improvement in the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
