villebro commented on code in PR #22430:
URL: https://github.com/apache/superset/pull/22430#discussion_r1049956480
##########
superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/index.js:
##########
@@ -35,7 +35,7 @@ const metadata = new ChartMetadata({
{ url: example2, caption: 'Grouped style' },
{ url: example3 },
],
- name: t('Bar Chart'),
+ name: t('Bar Chart (legacy)'),
Review Comment:
I think it might make sense to make this conditional on the feature flag
being flipped (`<feature flag check> ? 'Bar Chart (legacy)' : 'Bar Chart';`),
as an env that's not using generic x-axis will not have an alternative to the
legacy bar chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
