john-bodley opened a new pull request, #22435: URL: https://github.com/apache/superset/pull/22435
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR re-addresses some of the issues https://github.com/apache/superset/pull/20729 tried to fix which was closed in favor of https://github.com/apache/superset/pull/21066 (which introduced a few regressions). Specifically it: 1. Moves the Presto/Trino compatible `latest_partition` and `latest_sub_partition` functions—which are exposed as macros—from the `PrestoEngineSpec` to the `PrestoBaseEngineSpec` so they can be leveraged by the `TrinoEngineSpec`. 2. Adds missing facets to the `TrinoEngineSpec.extra_table_metadata` return value to include the latest partition spec, thus ensuing that the latest partition information is rendered in the left-hand panel. See the attached screenshot for details as previously this simply stated `latest partition:`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <img width="1317" alt="Screenshot 2022-12-16 at 1 37 09 PM" src="https://user-images.githubusercontent.com/4567245/207997067-548622fa-730c-4794-a2e8-e787f08d9ebe.png";> ### TESTING INSTRUCTIONS Added unit tests and end-to-end testing. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/4567245/207997067-548622fa-730c-4794-a2e8-e787f08d9ebe.png"](https://user-images.githubusercontent.com/4567245/207997067-548622fa-730c-4794-a2e8-e787f08d9ebe.png"){kind=link}