hughhhh commented on code in PR #22262:
URL: https://github.com/apache/superset/pull/22262#discussion_r1051015163
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx:
##########
@@ -271,16 +284,33 @@ const DatasetPanel = ({
component = (
<>
<StyledTitle>{COLUMN_TITLE}</StyledTitle>
- <TableContainer>
- <StyledTable
- loading={loading}
- size={TableSize.SMALL}
- columns={tableColumnDefinition}
- data={columnList}
- pageSizeOptions={pageSizeOptions}
- defaultPageSize={10}
- />
- </TableContainer>
+ {tableWithDataset ? (
+ <TableContainerWithBanner>
+ <TableScrollContainer>
+ <Table
+ loading={loading}
+ size={TableSize.SMALL}
+ columns={tableColumnDefinition}
+ data={columnList}
+ pageSizeOptions={pageSizeOptions}
+ defaultPageSize={25}
+ />
+ </TableScrollContainer>
+ </TableContainerWithBanner>
+ ) : (
+ <TableContainerWithoutBanner>
+ <TableScrollContainer>
+ <Table
+ loading={loading}
+ size={TableSize.SMALL}
+ columns={tableColumnDefinition}
+ data={columnList}
+ pageSizeOptions={pageSizeOptions}
+ defaultPageSize={25}
Review Comment:
can we make this a constant at the top?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
