mayurnewase commented on code in PR #22325: URL: https://github.com/apache/superset/pull/22325#discussion_r1051422148
########## superset/connectors/sqla/models.py: ########## @@ -2279,6 +2279,10 @@ class RowLevelSecurityFilter(Model, AuditMixinNullable): id = Column(Integer, primary_key=True) name = Column(String(255), unique=True, nullable=False) description = Column(Text) + # filter_type = Column( + # Enum(utils.RowLevelSecurityFilterType), + # info={"enum_class": utils.RowLevelSecurityFilterType}, + # ) Review Comment: I wanted to keep as its the recommended way on FAB, but will delete it. ########## superset/initialization/__init__.py: ########## @@ -215,6 +216,7 @@ def init_views(self) -> None: appbuilder.add_api(ReportScheduleRestApi) appbuilder.add_api(ReportExecutionLogRestApi) appbuilder.add_api(SavedQueryRestApi) + appbuilder.add_api(RLSRestApi) Review Comment: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org