eric-briscoe opened a new pull request, #22457: URL: https://github.com/apache/superset/pull/22457
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Add runtime safety checks and improved tests to recursivelyDeleteChildren and findParentId functions There have been cases where a dashboard ends up with an invalid componentId causing code in workspace to fail removal of a tab. The root cause of where the errant id comes from is still under investigation. This PR adds runtime safety checks to code that was fail when a bad ID existed to treat the symptom and make the application more fault tolerant. PR adds test to simulate bad states passed into functions to ensure they do not throw uncaught errors. PR also converts two files to TypeScript to make interfaces more clear. All existing tests were left unchanged to ensure previous behavior is stable. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable -->  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
