cccs-RyanK commented on PR #22084: URL: https://github.com/apache/superset/pull/22084#issuecomment-1359436893
> When `allowNewOptions` is enabled If you create multiple options and uncheck "Select all", all of the newly created options will be erased. This should not be the case > Select.-.Interactive.Select.Storybook.3.mp4 Thanks for the feedback @geido ! Made the suggested changes from your first two points. As for the last point you made about the new options being erased when they are deselected, I do think that this behaviour is consistent with how the component currently works. For example, before the select-all changes if you add new values by themselves and then deselect them, they are erased from the options. My thoughts are that deselecting-all should then also remove all the new options. Please let me know if that makes sense to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
