eschutho commented on code in PR #22043:
URL: https://github.com/apache/superset/pull/22043#discussion_r1054926017


##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx:
##########
@@ -106,6 +107,14 @@ export default function AddDataset() {
       getDatasetsList();
     }
   }, [dataset?.schema]);
+  const [showEditPage, setShowEditPage] = useState(false);

Review Comment:
   another wording suggestion: how about something like `editPageIsVisible` and 
`setEditPageIsVisible`? Just so it sounds like a boolean. You _could_ maybe 
leave out `is` if you wanted, too. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to