Antonio-RiveroMartnez commented on code in PR #22199:
URL: https://github.com/apache/superset/pull/22199#discussion_r1060818784
##########
superset/databases/api.py:
##########
@@ -280,6 +327,12 @@ def post(self) -> FlaskResponse:
if new_model.driver:
item["driver"] = new_model.driver
+ # Return SSH Tunnel and hide passwords if any
+ if item.get("ssh_tunnel"):
+ item["ssh_tunnel"] = new_model.ssh_tunnel # pylint:
disable=no-member
Review Comment:
Sure! I'll indeed use our `mask` as I did here:
https://github.com/apache/superset/pull/22513/files#diff-f9deb9b63f5f2db38b811ff092cf90b0d4d558223f743bbbb5b203c203d2d590R336
but sure, let me add that util. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
