EugeneTorap commented on code in PR #22355:
URL: https://github.com/apache/superset/pull/22355#discussion_r1062290488
##########
tests/integration_tests/datasource_tests.py:
##########
@@ -543,7 +543,7 @@ def test_get_samples_with_filters(test_client,
login_as_admin, virtual_dataset):
f"/datasource/samples?datasource_id={virtual_dataset.id}&datasource_type=table"
)
rv = test_client.post(uri, json=None)
- assert rv.status_code == 200
+ assert rv.status_code == 400
Review Comment:
Werkzeug 2.1.0 changelog:
> Request.get_json() will raise a 400 BadRequest error if the Content-Type
header is not application/json. This makes a very common source of confusion
more visible. https://github.com/pallets/werkzeug/issues/2339
If there's no json param or `json=None` then 400 http status will be thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
