john-bodley commented on code in PR #22413:
URL: https://github.com/apache/superset/pull/22413#discussion_r1062926578
##########
superset/models/helpers.py:
##########
@@ -327,7 +327,10 @@ def import_from_dict(
# Recursively create children
if recursive:
for child in cls.export_children:
- child_class =
cls.__mapper__.relationships[child].argument.class_
+ argument = cls.__mapper__.relationships[child].argument
Review Comment:
The relationship
[argument](https://docs.sqlalchemy.org/en/14/orm/relationship_api.html#sqlalchemy.orm.relationship.params.argument)
can either be a mapped class or instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
