codyml commented on code in PR #22610:
URL: https://github.com/apache/superset/pull/22610#discussion_r1063891312
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx:
##########
@@ -104,7 +100,8 @@ function Footer({
if (typeof response === 'number') {
logEvent(LOG_ACTIONS_DATASET_CREATION_SUCCESS, datasetObject);
// When a dataset is created the response we get is its ID number
- goToPreviousUrl();
+ window.location.href =
Review Comment:
Oops sorry, I missed that in the designs – if we're intentionally changing
that flow so it always ends you at the Edit Dataset view no matter where the
user started then please disregard. I'm fine with how it is now (redirect to
the dataset list) as a temporary solution but @AAfghahi's suggestion works too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
