villebro opened a new pull request, #22659: URL: https://github.com/apache/superset/pull/22659
### SUMMARY #21018 added memoization of common bootstrap data to avoid repetitive calls to regenerate user perms in bootstrap data. However, this had the side-effect of also using cached toasts, causing toasts to either 1) not display 2) display with a lag and not clear. This breaks out the expensive logic from `common_bootstrap_payload` into a separate function `cached_common_bootstrap_data` which is memoized, and always checks flashed messages to ensure that they always accurately reflect the current toasts. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
