artemonsh opened a new pull request, #22660: URL: https://github.com/apache/superset/pull/22660
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> 1. For dashboards with long title all elements don't fit to screen anymore and horizontal scrolling appears. This PR is an attempt to solve this issue. 2. I suggest to show not 1 but 2 lines of the title if it is long enough (which is a common practice in my company). The overflow will be hidden as it was before. It is done with help of CSS properties webkit-line-clamp and webkit-box-orient (example [here](https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-line-clamp)). ### BEFORE  ### AFTER  ### BEFORE vs AFTER video (with sound) https://user-images.githubusercontent.com/53895552/211523820-fe913c9f-d387-450c-ada0-72a1ba7572ee.mp4 ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Create a dashboard with a very long title. You can take it from this website: https://www.lipsum.com ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/22520 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
