villebro commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1066853176
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Ok, I read through some docs. Am I right in the following assumptions?
- The env variable only blocks `puppeteer` from downloading chrome when the
docker image is being built during `npm ci`
- We're not depending on this functionality indirectly despite pulling in
`puppeteer` in our npm deps
@nisheldo please add a summary of what kind of error you're getting without
this fix, preferably a dump of the docker build error you're seeing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
