villebro commented on PR #22462: URL: https://github.com/apache/superset/pull/22462#issuecomment-1378586781
> Yes, it's regression bug from my PR because we don't have unit tests for the logic. > In order to prevent the regression bug in the future we need to cover everything with unit tests. @EugeneTorap looking more closely it seems it's the missing pinning that was the problem. So we should have restricted to `<0.5` before, and now we should probably have `<0.7` to avoid similar breakage going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
