lyndsiWilliams commented on code in PR #22610:
URL: https://github.com/apache/superset/pull/22610#discussion_r1068554617
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx:
##########
@@ -1231,7 +1231,7 @@ const DatabaseModal:
FunctionComponent<DatabaseModalProps> = ({
onClick={() => {
setLoading(true);
fetchAndSetDB();
- window.location.href = '/tablemodelview/list#create';
+ window.location.href = '/dataset/add/';
Review Comment:
Fixed in [`this
commit`](https://github.com/apache/superset/pull/22610/commits/a72d05829371f6a375e165dd2d3739474587fa63).
I found another `window.location.href` a little further down so I changed that
to use `history.push()` as well.
##########
superset-frontend/src/views/CRUD/data/hooks.ts:
##########
@@ -80,6 +81,7 @@ export const UseGetDatasetsList = (queryParams: string |
undefined) =>
endpoint: `/api/v1/dataset/?q=${queryParams}`,
})
.then(({ json }) => json)
- .catch(error =>
- logging.error('There was an error fetching dataset', error),
- );
+ .catch(error => {
+ addDangerToast('There was an error fetching dataset');
Review Comment:
Fixed in [`this
commit`](https://github.com/apache/superset/pull/22610/commits/a72d05829371f6a375e165dd2d3739474587fa63).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
