eric-briscoe commented on issue #22705: URL: https://github.com/apache/superset/issues/22705#issuecomment-1382592945
I believe this issue was introduced by this PR: https://github.com/apache/superset/pull/18576/files#diff-0cf142796bd16ac5769ddcb30d41eda23c36ca61176dba4521e2125bd87da01c that adds use of window.sessionStorage in a new file. This PR merged to master branch about 11 months ago, but would not have showed up in a release until 2.0.0 and 2.0.1. This PR fixes the same error reported here and was merged to master ~5 month ago: https://github.com/apache/superset/pull/21157/files which I do not think made it into 2.0.0 or 2.0.1. @treygilliland to clarify, have you used 2.0.0 under same conditions and not had this error, or did you skip 2.0.0 and have only used 2.0.1 and are coming from 1.5.x version prior to this? For more context, most browsers disable access to localStorage and sessionStorage when running in incognito / private modes. The PR that fixes the runtime error added a safety check to ensure window.localStorage and window.sessionStorage are available before calling them. @AAfghahi @eschutho we should tag https://github.com/apache/superset/pull/21157/files with a 2.0 label so we can chery it in as the fix for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
