geido opened a new pull request, #22785: URL: https://github.com/apache/superset/pull/22785
### SUMMARY This PR does the following: - Removes the ability to emit cross filters from Explore - Moves the emission of cross filters at the Dashboard level - Removes the cross filter target name introduced in https://github.com/apache/superset/issues/13966 - Moves the filter bar location settings in a submenu ### AFTER https://user-images.githubusercontent.com/60598000/213498463-4b990134-247b-4033-9061-cbd617e7be13.mp4 ### TESTING INSTRUCTIONS 1. Go to a Dashboard 2. Open the filter bar on the left 3. Click on the settings icon 4. Make sure the checkbox to enable/disable cross filters is appearing 5. Verify that cross filters are enabled by default (requires Feature Flag DASHBOARD_CROSS_FILTERS) 7. Disable cross filtering and make sure the change takes effect 8. Verify that the filter bar orientation settings are appearing in a submenu and working as intended ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Required feature flags: DASHBOARD_CROSS_FILTERS - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
