[GitHub] [superset] justinpark opened a new pull request, #22793: chore(dashboard): Log events for download as image

[GitBox]

justinpark opened a new pull request, #22793:
URL: https://github.com/apache/superset/pull/22793

   ### SUMMARY
   This commit adds the logger for "download as image" link on both dashboard 
menu and chart menu.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   - Dashboard
   
   <img width="569" alt="Screenshot 2023-01-19 at 2 56 03 PM" 
src="https://user-images.githubusercontent.com/1392866/213581992-387f02e1-aa7a-44ae-861c-2ed05ddfd148.png";>
   
   - Chart
   <img width="567" alt="Screenshot 2023-01-19 at 3 02 14 PM" 
src="https://user-images.githubusercontent.com/1392866/213581954-c9710279-0f53-4e31-8f06-5c50adffd3f1.png";>
   
   ### TESTING INSTRUCTIONS
   - Open a dashboard
   - click dropdown menu > "Download as image"
   - Check the network tab for the logging event
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org