michael-s-molina opened a new pull request, #22830:
URL: https://github.com/apache/superset/pull/22830

   ### SUMMARY
   Updates `Select` to correctly handle disabled options on Select All.
   
   Follow-up of https://github.com/apache/superset/pull/22084
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/214135879-d4502cc7-3e8a-4543-883d-4637b07d7ad0.mov
   
   ### TESTING INSTRUCTIONS
   - Select All should count only disabled options that are selected initially.
   - Select All should NOT count disabled options that are unselected.
   - Select All shouldn't change the original state of disabled options.
   - Clear All should preserve disabled options that are selected initially.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to