hughhhh commented on code in PR #20876:
URL: https://github.com/apache/superset/pull/20876#discussion_r1088026004
##########
superset/dashboards/api.py:
##########
@@ -212,20 +215,37 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
edit_columns = add_columns
search_columns = (
- "created_by",
- "changed_by",
- "dashboard_title",
- "id",
- "owners",
- "published",
- "roles",
- "slug",
+ (
+ "created_by",
+ "changed_by",
+ "dashboard_title",
+ "id",
+ "owners",
+ "published",
+ "roles",
+ "slug",
+ )
+ if not is_feature_enabled("TAGGING_SYSTEM")
Review Comment:
just append `tags` `if is_feature_enabled("TAGGING_SYSTEM")` lets use
positive logic here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
