jfrag1 commented on code in PR #22887:
URL: https://github.com/apache/superset/pull/22887#discussion_r1089074009
##########
superset/views/base_api.py:
##########
@@ -107,13 +106,14 @@ def statsd_metrics(f: Callable[..., Any]) ->
Callable[..., Any]:
"""
def wraps(self: "BaseSupersetModelRestApi", *args: Any, **kwargs: Any) ->
Response:
Review Comment:
This type can now be `BaseSupersetApi` as well (or anything that inherits
from `BaseSupersetApiMixin`, not sure the best way to type-hint this though
##########
superset/utils/log.py:
##########
@@ -194,7 +195,7 @@ def log_with_context( # pylint: disable=too-many-locals
slice_id = 0
if log_to_statsd:
- self.stats_logger.incr(action)
+ stats_logger_manager.instance.incr(action)
Review Comment:
Should the `stats_logger` property on this class be removed as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
