rusackas commented on code in PR #22772:
URL: https://github.com/apache/superset/pull/22772#discussion_r1089267077
##########
superset-frontend/plugins/legacy-plugin-chart-calendar/src/Calendar.js:
##########
@@ -88,7 +88,8 @@ function Calendar(element, props) {
Object.keys(metricsData).forEach(metric => {
const calContainer = div.append('div');
if (showMetricName) {
- calContainer.text(`Metric: ${verboseMap[metric] || metric}`);
+ // eslint-disable-next-line prefer-template
+ calContainer.text(t('Metric') + `: ${verboseMap[metric] || metric}`);
Review Comment:
Thanks, this helps explain the situation wonderfully. Here I was thinking we
lived in a simpler world! It would be nice to find _some_ way to get the
template literals to _work_, since I think they're a lot cleaner, but that's
not the value we're going for at this very moment, and these individual
instances seem like trivial tech debt to sweep up if we ever do sort that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
