john-bodley commented on PR #22896: URL: https://github.com/apache/superset/pull/22896#issuecomment-1409400108
I guess the gist of what Superset is trying to do is to try to ensure that users are cognizant (or potentially forbidden) that updating a chart could impact numerous dashboards which the various dashboard owners are oblivious to, i.e., their dashboard now includes a chart which has been augmented in some way which is now either mislead or wrong in the context of their dashboard. Personally I find the whole Superset permission system rather complex (especially given AFAIK there's no explicit/serialized form of the policy). I'm supportive of said change, but would like some additional eyes to ensure we're not violating some rule—though the pass unit/integration tests gives be confidence that we're not. Maybe @michael-s-molina or @villebro who likely know how this _should_ work could also review the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
