geido opened a new pull request, #22936: URL: https://github.com/apache/superset/pull/22936
### SUMMARY This PR https://github.com/apache/superset/issues/22707 moved the `stopPropagation` event downstream but wasn't removed upstream causing a bug with removing metrics. ### BEFORE https://user-images.githubusercontent.com/60598000/216051640-e7c1309e-bd7e-4a08-b155-616dc7b7dca7.mov ### TESTING INSTRUCTIONS - Run query in SQL lab and create chart OR create a chart from a dataset - Add metric - Try to delete it via clicking "x" - The metric should be deleted successfully ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
