[GitHub] [superset] justinpark opened a new pull request, #22990: fix(sqllab): clean unwanted scrollbar

[via GitHub]

justinpark opened a new pull request, #22990:
URL: https://github.com/apache/superset/pull/22990

   ### SUMMARY
   
   _Regression by #22474_
   
   When `.gutter` style migrated to emotion, the margin size has been updated 
incorrectly.
   As a result, a unwanted scrollbar in sqllab editor has been shown due to the 
unmatched margin size.
   
   This commit updates the `.gutter` margin matching with the constant.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   -Before:
   
   <img width="1170" 
alt="Superset_and_Inbox__1_963__-_justin_park_airbnb_com_-_Airbnb_com_Mail" 
src="https://user-images.githubusercontent.com/1392866/216682518-1517a90b-7430-4e0f-bee6-bc4cdaaa6c38.png";>
   
   - After:
   
   <img width="1164" alt="Screenshot 2023-02-03 at 10 37 15 AM" 
src="https://user-images.githubusercontent.com/1392866/216682575-f6611539-55a1-4318-8ac4-c4f7d339e1ec.png";>
   
   ### TESTING INSTRUCTIONS
   Go to sqllab and check the scrollbar on editor panel
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc: @kgabryje @ktmud 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org