[GitHub] [superset] kgabryje commented on pull request #23138: feat: Cross Filters in FilterBar

[via GitHub]

kgabryje commented on PR #23138:
URL: https://github.com/apache/superset/pull/23138#issuecomment-1441697419

   A few more comments:
   1. I think the search icon is not centered. I fixed it by giving the 
`span.anticon` `line-height: 0`. 
   <img width="187" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220905877-0f78ff1f-8a6e-4247-8618-9e3a28b4120e.png";>
   
   2. The spacing between the X and the right edge of the tag is slightly too 
large - 8px instead of 4 
   <img width="228" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220906743-4d93c5d3-0777-4bfc-af2f-a73f9a2803c7.png";>
   
   3. I think the separator line is redundant if there are no native filters 
added 
   <img width="475" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220906572-f75ccd2d-8600-4ab9-ac75-a7c91a64f88b.png";>
   
   4. If there are no native filters, there's a vertical line in the "More 
filters" dropdown 
   <img width="353" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220907003-f0943172-e8a0-49f8-a33f-28c69985a45c.png";>
   
   5. Not sure what to do about that empty state here... 
   <img width="311" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220907229-82a65f4b-bdcb-4f04-b15d-b7db33430f42.png";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org