[GitHub] [superset] justinpark opened a new pull request, #23257: chore(sqllab): Remove schemaOptions from redux store

[via GitHub]

justinpark opened a new pull request, #23257:
URL: https://github.com/apache/superset/pull/23257

   ### SUMMARY
   As a followup step of the `react-query` migration (#21240), this commit 
migrates the schemaOptions state from redux to react-query to reduce the 
complexity of the queryEditor state.
   (The `schemaOptions` state only used in the editor for autocomplete so 
useQuery is a lighter way to share the state)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   - After:
   
   <img width="382" alt="Screenshot 2023-03-01 at 11 55 04 AM" 
src="https://user-images.githubusercontent.com/1392866/222254800-56963b22-10a2-4bcf-8484-a0605535d485.png";>
   <img width="527" alt="Screenshot 2023-03-01 at 12 02 48 PM" 
src="https://user-images.githubusercontent.com/1392866/222254869-2f296a20-56dc-4188-8ba0-130b8ff10959.png";>
   
   - Before:
   
   <img width="377" alt="Notification_Center" 
src="https://user-images.githubusercontent.com/1392866/222254686-83138e28-3aa8-4c2e-a7e7-a7018f53c6be.png";>
   <img width="529" alt="Screenshot 2023-03-01 at 12 04 40 PM" 
src="https://user-images.githubusercontent.com/1392866/222254909-b1ffe428-534f-4fd8-baa6-b2e3ec14ac01.png";>
   
   ### TESTING INSTRUCTIONS
   Go to sqllab and select a database to get the associated schemas
   Type some part of the schema name on the editor and check the autocomplete 
including the fetched schemas
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc: @ktmud 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org