john-bodley commented on code in PR #23269:
URL: https://github.com/apache/superset/pull/23269#discussion_r1128542764
##########
superset/utils/dashboard_filter_scopes_converter.py:
##########
@@ -88,3 +90,160 @@ def copy_filter_scopes(
if int(slice_id) in old_to_new_slc_id_dict
]
return new_filter_scopes
+
+
+def convert_filter_scopes_to_native_filters( # pylint:
disable=invalid-name,too-many-locals,too-many-nested-blocks
Review Comment:
This logic is taken from https://github.com/apache/superset/pull/16992
(specifically the
[ilterboxMigrationHelper.ts](https://github.com/graceguo-supercat/superset/blob/3a27565fe65f4f166ea7ade3d1ee8580ef8f9c17/superset-frontend/src/dashboard/util/filterboxMigrationHelper.ts)
file). Note however the logic here is considerably simpler, i.e., there's no:
1. Druid logic as the Druid NoSQL connector has been deprecated.
2. Complex dependency logic†.
† The reason being is previously the legacy filter-box charts remained in
the dashboards and thus there needed to be additional logic to wire up the
parent/child relationships between the native filters and legacy filter-box
charts. In the current formulation the filter-box charts have been removed
(having been replaced with markdown elements) and thus said logic isn't
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
