eschutho commented on code in PR #23290:
URL: https://github.com/apache/superset/pull/23290#discussion_r1130284221
##########
superset/utils/webdriver.py:
##########
@@ -176,22 +176,46 @@ def get_screenshot(
sleep(selenium_headstart)
try:
- logger.debug("Wait for the presence of %s", element_name)
- element = WebDriverWait(driver,
self._screenshot_locate_wait).until(
- EC.presence_of_element_located((By.CLASS_NAME, element_name))
- )
+ try:
+ # page didn't load
+ logger.debug(
+ "Wait for the presence of %s at url: %s", element_name, url
+ )
+ element = WebDriverWait(driver,
self._screenshot_locate_wait).until(
+ EC.presence_of_element_located((By.CLASS_NAME,
element_name))
+ )
Review Comment:
These are most likely going to be network errors, i.e., server is down or
url is incorrect, or perhaps permissions - user can't access the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
