kasiazjc commented on PR #23244: URL: https://github.com/apache/superset/pull/23244#issuecomment-1462152529
> @kasiazjc what do you think about the styling on this page? Seems to match other table based pages, I think we could fix some of the spacings/margins, but it would be another project for all of the CRUD view style pages. I have a few things to consider/check though: - I think we might be missing left padding in the header (might be a screenshot problem) - I think we could also replace the header with the global header component that we use in chart builder and dashboards. Then we do not have to worry about styling + we could add "more" or some kind of "settings" button on the right of the header to make it easier to edit the properties of the report. Need @yousoph opinion though as I am not that familiar with this part of our product. Would it even be useful? - We do not use "back to all" button logic anywhere in the app as far as I'm aware . If this works well with all of the browser back buttons we can get rid of the one implemented. I'm trying to figure out if there is a way to better communicate the type of of the object we are browsing. I think we could use metadata bar in header with first entry being "type=report". Adding a quick mock below. Not sure what other info could be included though than owner, description (I think there is one)? Maybe schedule? <img width="1243" alt="image" src="https://user-images.githubusercontent.com/36897697/224053803-981da4e0-5b43-4e42-9a49-f298d2202f39.png";> (do not mind the table, this is random one from the mock I found) Turns out it's a lot of ideas, @yousoph @eschutho need your opinion on what we can/want/don't want to do here right now. From my perspective using global header, removing back to all and adding a way to access report settings modal (if that makes sense) from this page would be a way to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/36897697/224053803-981da4e0-5b43-4e42-9a49-f298d2202f39.png"](https://user-images.githubusercontent.com/36897697/224053803-981da4e0-5b43-4e42-9a49-f298d2202f39.png"){kind=link}